Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_s3outposts_endpoint: Fix timeout duration for creation #18454

Merged
merged 1 commit into from
Apr 29, 2021
Merged

r/aws_s3outposts_endpoint: Fix timeout duration for creation #18454

merged 1 commit into from
Apr 29, 2021

Conversation

qrevel
Copy link
Contributor

@qrevel qrevel commented Mar 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

The documentation about creating an Outpost S3 endpoint says:

It can take up to 20 minutes for your Outposts endpoint to be created and your bucket to be ready to use.

I am aware the API doc says that it should only take 5 minutes. An issue has been raised on the AWS to update this documentation. Currently 5 mins is too short and it timeouts when the endpoint is created through Terraform.

Output from acceptance testing:

I could not run the acceptance test on outpost.

@qrevel qrevel requested a review from a team as a code owner March 29, 2021 08:19
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/s3outposts Issues and PRs that pertain to the s3outposts service. labels Mar 29, 2021
github-actions[bot]
github-actions bot reviewed Mar 29, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @qrevel 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 29, 2021
gdavison
gdavison approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

gdavison added a commit that referenced this pull request Apr 29, 2021
@gdavison
Merge pull request #18454 from qrevel/main
3db0522
@gdavison gdavison merged commit 10eadab into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
service/s3outposts Issues and PRs that pertain to the s3outposts service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qrevel @gdavison @breathingdust